Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRCF: Small Fixes #3314

Merged
merged 2 commits into from
May 17, 2024
Merged

BRCF: Small Fixes #3314

merged 2 commits into from
May 17, 2024

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

Corrects EventDict typing, adds newline to end of files, removes unused imports, spacing/formatting fixes, corrects millennium_mall_all_challenges signature, corrects a typo, fixes a link, corrects a test for membership (not x in y -> x not in y), fixes some lambda reference error.

How was this tested?

Unit tests, PyCharm, 1500 random generations.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 17, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels May 17, 2024
Copy link
Collaborator

@TRPG0 TRPG0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TRPG0 TRPG0 removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label May 17, 2024
@NewSoupVi NewSoupVi merged commit b4b79bc into ArchipelagoMW:main May 17, 2024
16 checks passed
@Exempt-Medic Exempt-Medic deleted the brcf-changes branch June 1, 2024 13:47
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
* Plural fix

* Update link
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* Plural fix

* Update link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants