KDL3: Version 2.0.0

[Silvris]

What is this fixing or adding?

Major overhaul/cleanup of the KDL3 world.

Features:

• Now using APPP, supporting generation without the need for a rom
• Now has local items by default, with an option to enable remote items
• More varied filler item generation
• Trap percentage now applies to the entire filler pool, not just filler created from non-required Heart Stars
• Now supports a maximum of 99 Heart Stars per world
• Added option groups
• Added Miku Kirby flavor

Fixes:

• Typing cleanup across the entire world, including some cases where the variables were incorrect types
• Fixed an issue with prior restrictive ability fill on Ripple Field 5, where Burning is not actually a valid option for the fill
• Fixed an issue where 2 animals could appear in the same room, and if ridden could crash the game.
• Fixed Custom Kirby/Gooey Flavor not having display names
• Fixed the All Random preset not including random starsanity
• Fixed two animal locations in Iceberg 4 not having access rules
• Fixed a bug where if Kirby died while Gooey was alive and a Gooey Bag was primed, the game would crash
• Fixed a test that would not run correctly
• Fixed an issue where Boss Shuffle would be nonfunctional if Stage Shuffle was disabled

How was this tested?

Minimally, most changes have been tested manually via test generations and client testing, but not a full playthrough.
Ran unittests.

If this makes graphical changes, please attach screenshots.

[NewSoupVi]

There are conflicts & I think agilbert1412 makes good points that should at the very least be addressed (i.e. commented on), so I'm putting this on waiting on author

[NewSoupVi]

Code looks good, unit tests give me confidence

As said on Discord, I would like some sort of playtesting to happen before I click merge because a lot of changes are rom stuff (so I'm gonna do "Request changes")

[TheLX5]

Not an official play test but my friend group has played this content update for a while now every now and then in our weekly sessions and we can confirm that most of the changes and additions work fine (we didn't test everything as our sessions were made with options we're comfortable with instead of playing for testing).

Can vouch for proper APPP usage as I'm using this world as a base for my own worlds which has been working nicely and matches the usage seen in other merged worlds as well (MLSS).

[TheLX5]

Using the pattern option in stage_shuffle breaks generation, tested on the latest commit.

Exception in <bound method create_levels of <worlds.kdl3.KDL3World object at 0x0000021213DCE9D0>> for player 1, named Player1.
Traceback (most recent call last):
  File "A:\Archipelago\generate.py", line 551, in <module>
    multiworld = ERmain(erargs, seed)
                 ^^^^^^^^^^^^^^^^^^^^
  File "A:\Archipelago\Main.py", line 110, in main
    AutoWorld.call_all(multiworld, "create_regions")
  File "A:\Archipelago\worlds\AutoWorld.py", line 181, in call_all
    call_single(multiworld, method_name, player, *args)
  File "A:\Archipelago\worlds\AutoWorld.py", line 171, in call_single
    raise e
  File "A:\Archipelago\worlds\AutoWorld.py", line 164, in call_single
    ret = _timed_call(method, *args, multiworld=multiworld, player=player)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "A:\Archipelago\worlds\AutoWorld.py", line 150, in _timed_call
    ret = method(*args)
          ^^^^^^^^^^^^^
  File "A:\Archipelago\worlds\kdl3\regions.py", line 235, in create_levels
    world.player_levels = generate_valid_levels(world, level_shuffle)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "A:\Archipelago\worlds\kdl3\regions.py", line 159, in generate_valid_levels
    raise Exception(
Exception: Failed to find valid stage for 5-5. Remaining Stages:[7798788]
Exception in <bound method create_levels of <worlds.kdl3.KDL3World object at 0x0000021213DCE9D0>> for player 1, named Player1.