Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Remove @jtoyoda as world maintainer for Final Fantasy #3398

Merged
merged 1 commit into from
May 29, 2024

Conversation

ThePhar
Copy link
Member

@ThePhar ThePhar commented May 25, 2024

What is this fixing or adding?

Removing as world maintainer based on this comment: #3284 (comment)

Keeping ff1 world in worlds as world still works, but may move to worlds_disabled if world compatibility breaks with no new maintainer to take on the role.

How was this tested?

N/A

If this makes graphical changes, please attach screenshots.

N/A

@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label May 25, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 25, 2024
@ThePhar ThePhar added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 25, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ftr, ff1 was not voted on, so there are no poll results to post here.

Not sure I like the new comment style better than the old, but it's fine.

@ThePhar ThePhar merged commit 34f903e into ArchipelagoMW:main May 29, 2024
3 checks passed
@ThePhar ThePhar deleted the ff1_remove_maintainer branch May 29, 2024 14:59
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants