Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingo: Fixing KeyError from name change #3449

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Lingo: Fixing KeyError from name change #3449

merged 1 commit into from
Jun 3, 2024

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

Test failures because Orange Tower Seventh Floor - Mastery was renamed to The Fearless - MASTERY

How was this tested?

Unit Tests.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 3, 2024
@ThePhar ThePhar requested a review from hatkirby June 3, 2024 11:49
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 3, 2024
hatkirby
hatkirby approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct way of fixing that issue. Thanks!

@hatkirby hatkirby added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. affects: release/blocker Issues/PRs that must be addressed before next official release. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 3, 2024
@NewSoupVi NewSoupVi merged commit c7eef13 into ArchipelagoMW:main Jun 3, 2024
16 checks passed
@Exempt-Medic Exempt-Medic deleted the patch-4 branch June 4, 2024 14:51
wu4 pushed a commit to wu4/Archipelago that referenced this pull request Jun 6, 2024
@Exempt-Medic @wu4
Accounting for name change (ArchipelagoMW#3449)
c2d83ad
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@Exempt-Medic @agilbert1412
Accounting for name change (ArchipelagoMW#3449)
e6da119
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@Exempt-Medic
Accounting for name change (ArchipelagoMW#3449)
b6335e6
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@Exempt-Medic @sflavelle
Accounting for name change (ArchipelagoMW#3449)
27e3ef7
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Exempt-Medic @qwint
Accounting for name change (ArchipelagoMW#3449)
8a9c98f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@hatkirby hatkirby hatkirby approved these changes

Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exempt-Medic @hatkirby @NewSoupVi @ThePhar