HK: lower max egg cost #3463
Merged
HK: lower max egg cost #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so if a random filler egg isn't generated 21 max egg costs can be unreachable could be updated when/if tuk check adds an egg to the pool
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
approved these changes
Jun 4, 2024
Exempt-Medic
added
is: bug/fix
|
Any bets on whether we remember to revert this with the rewrite? |
BadMagic100
added
waiting-on: core-review
BadMagic100
approved these changes
Jun 5, 2024
ThePhar
approved these changes
Jun 5, 2024
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
per extractedData pool_options, only 20 eggs are created by default, so if a random filler egg isn't generated 21 max egg costs can be unreachable
could be updated when/if tuk check adds an egg to the default pool
How was this tested?
wasn't
If this makes graphical changes, please attach screenshots.