Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hk: adds schema to validate plando charm costs #3471

Merged
merged 1 commit into from
Jun 7, 2024
Merged

hk: adds schema to validate plando charm costs #3471

merged 1 commit into from
Jun 7, 2024

Conversation

qwint
Copy link
Contributor

@qwint qwint commented Jun 5, 2024

What is this fixing or adding?

adds schema to validate plando charm costs

How was this tested?

just ran generations,
3 charms set to 0, gen'd as expected
each failed as expected: with a typo, with a negative cost, with too high a cost

If this makes graphical changes, please attach screenshots.

@qwint qwint requested a review from ThePhar as a code owner June 5, 2024 17:33
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 5, 2024
BadMagic100
BadMagic100 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@BadMagic100 BadMagic100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this could support weights similar to messenger shop plando but certainly not blocking

@BadMagic100 BadMagic100 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. is: enhancement Issues requesting new features or pull requests implementing new features. labels Jun 5, 2024
@Berserker66 Berserker66 merged commit b053fee into ArchipelagoMW:main Jun 7, 2024
16 checks passed
@qwint qwint deleted the hk_plando_schema branch June 7, 2024 17:12
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@qwint @agilbert1412
HK: adds schema to validate plando charm costs (ArchipelagoMW#3471)
9d6fec7
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@qwint
HK: adds schema to validate plando charm costs (ArchipelagoMW#3471)
06ce430
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@qwint @sflavelle
HK: adds schema to validate plando charm costs (ArchipelagoMW#3471)
2d8ff23
qwint added a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@qwint
HK: adds schema to validate plando charm costs (ArchipelagoMW#3471)
4e1b27b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadMagic100 BadMagic100 BadMagic100 approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

@ThePhar ThePhar Awaiting requested review from ThePhar

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwint @Berserker66 @BadMagic100