Core: hot reload components from installed apworld #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
black-sliver
reviewed
Jun 6, 2024
`Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds)
beauxq
commented
Jun 6, 2024
Comment on lines
+127
to
+133
| found_already_loaded = False | ||
| for loaded_world in worlds.world_sources: | ||
| loaded_name = pathlib.Path(loaded_world.path).stem | ||
| if module_name == loaded_name: | ||
| found_already_loaded = True | ||
| break | ||
| if found_already_loaded: |
There was a problem hiding this comment.
Don't you dare tell me to use for else - I'm not doing it.
There was a problem hiding this comment.
if only there was a way to get rid of the temp found_already_loaded
black-sliver
reviewed
Jun 6, 2024
| @@ -48,7 +49,7 @@ class WorldSource: | |||
| path: str # typically relative path from this module | |||
| is_zip: bool = False | |||
| relative: bool = True # relative to regular world import folder | |||
| time_taken: Optional[float] = None | |||
| time_taken: float = -1.0 | |||
There was a problem hiding this comment.
Always smuggling in some typing fixes
There was a problem hiding this comment.
This is a runtime error I ran into with the changes I made.
'<' not supported between instances of 'NoneType' and 'float'
because this dataclass says that it's ordered.
There was a problem hiding this comment.
(The smuggled in was typings/schema/__init__.pyi - That has nothing to do with this PR.) 😛
wu4
pushed a commit
to wu4/Archipelago
that referenced
this pull request
Jun 6, 2024
* Core: hot reload components from installed apworld * address PR reviews `Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds) * clarify that the installation is successful
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
* Core: hot reload components from installed apworld * address PR reviews `Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds) * clarify that the installation is successful
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Core: hot reload components from installed apworld * address PR reviews `Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds) * clarify that the installation is successful
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
* Core: hot reload components from installed apworld * address PR reviews `Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds) * clarify that the installation is successful
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Core: hot reload components from installed apworld * address PR reviews `Launcher` widget members default to `None` so they can be defined in `build` `Launcher._refresh_components` is not wrapped loaded world goes into `world_sources` so we can check if it's already loaded. (`WorldSource` can be ordered now without trying to compare `None` and `float`) (don't load empty directories so we don't detect them as worlds) * clarify that the installation is successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I saw this comment: #3472 (review)
New buttons appear in Launcher when you install apworld.
There are probably still some things that don't work without restarting the Launcher, but this covers a lot of what players will want to do.
How was this tested?
button.apworldwith nothing but a new component buttonLauncher.pybutton.apworldonto Launcher windowprintto console)ff6wc.apworldonto Launcher windowsubversion.apworldonto Launcher windowPlayersdid not test frozen