Test: hosting: handle writes during start_room #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: maybe we'd also want to add such handling to WebHost itself,
but this is out of scope for getting hosting test to work.
github-actions
bot
added
the
waiting-on: peer-review
|
When this happens on actual webhost, if I understand it correctly, it would skip that one spinup request, then present an internal server error to the user, correct? |
Berserker66
approved these changes
Jun 8, 2024
|
That's my understanding of it, yes. |
agilbert1412
pushed a commit
to agilbert1412/Archipelago
that referenced
this pull request
Jun 13, 2024
Note: maybe we'd also want to add such handling to WebHost itself,
but this is out of scope for getting hosting test to work.
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
Note: maybe we'd also want to add such handling to WebHost itself,
but this is out of scope for getting hosting test to work.
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
Note: maybe we'd also want to add such handling to WebHost itself,
but this is out of scope for getting hosting test to work.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Note: maybe we'd also want to add such handling to WebHost itself,
but this is out of scope for getting hosting test to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The
/room/<room>route can fail if autohoster writes to DB at the same time. This change will simply retry in hosting test if that happens.Should fix the failed run
https://github.com/ArchipelagoMW/Archipelago/actions/runs/9421679862/job/25956273385?pr=3489
that was posted on Discord
Maybe we'd also want to add such handling to WebHost itself, but this is out of scope for getting hosting test to work.
How was this tested?
Test still works.