WebHost: Better host room #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fetch instead of post and faster refresh after command
github-actions
bot
added
the
affects: webhost
Charset is separate from mimetype in flaask, so this gets appended automatically (and defaults to utf-8)
Exempt-Medic
added
the
is: enhancement
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
* add Range= to log, making responses a lot smaller for massive rooms * switch xhr to fetch * post the form using fetch if possible * also refresh log faster while waiting for command echo / response * do not follow redirect, saving a request * do not post empty body * smooth-scroll the log view * paste the log into the div when loading the HTML (up to 1MB, rest will be `fetch`ed) * fix duplicate charset in display_log response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
fetched)How was this tested?
Side notes:
I really dislike the 2 spaces indentation, but I guess this is set in stone?
I feel like
scrollToBottomis something I would want to paste into a utils.js or helper.js, but we don't have/load a helper "bundle".The jsdoc is because it seems like PyCharm pro does not infer the actual type for getElementById.