Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLSS: Fix for Xp scaling when set to 0 #3498

Merged
merged 1 commit into from
Jun 9, 2024
Merged

MLSS: Fix for Xp scaling when set to 0 #3498

merged 1 commit into from
Jun 9, 2024

Conversation

jamesbrq
Copy link
Contributor

@jamesbrq jamesbrq commented Jun 9, 2024

What is this fixing or adding?

Removes an unnecessary if statement that would equate to false if Xp scaling was set to the minimum range of 0.

How was this tested?

Generated a game with yaml option set to 0 for xp scaling and successfully patched a game.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 9, 2024
nicholassaylor
nicholassaylor approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 9, 2024
Exempt-Medic
Exempt-Medic approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't see any other similar cases in the file either

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 9, 2024
@NewSoupVi NewSoupVi merged commit 5f8a8e6 into ArchipelagoMW:main Jun 9, 2024
17 checks passed
agilbert1412 pushed a commit to agilbert1412/Archipelago that referenced this pull request Jun 13, 2024
@jamesbrq @agilbert1412
Update Rom.py (ArchipelagoMW#3498)
905d842
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@jamesbrq
Update Rom.py (ArchipelagoMW#3498)
0df5f86
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@jamesbrq @sflavelle
Update Rom.py (ArchipelagoMW#3498)
94918c8
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@jamesbrq @qwint
Update Rom.py (ArchipelagoMW#3498)
0e54739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesbrq @NewSoupVi @Exempt-Medic @nicholassaylor