TUNIC: Entrance rando Direction Pairs + Decoupled #3761
+1,119
−503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hesto2
reviewed
Oct 1, 2024
# worlds/tunic/__init__.py # worlds/tunic/combat_logic.py # worlds/tunic/er_data.py # worlds/tunic/er_rules.py # worlds/tunic/er_scripts.py
github-actions
bot
added
affects: core
ScipioWright
removed
affects: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds two new options: Direction Pairs and Decoupled.
Direction Pairs: Entrances will always lead to entrances opposite them -- North entrances lead to South entrances, Ladder Up to Ladder Down, Floor to Floor, etc. This option was put into an Entrance Layout option, whose options are Standard, Fixed Shop, and Direction Pairs (since Fixed Shop and Direction Pairs are completely incompatible with each other).
Decoupled: Portal connections are not necessarily two-way with this enabled. Be brave, tiny, lost fox.
Plando Connections has been updated to deal with these new options, and you can plando up to 500 shops into the pool, since every shop is the same shop anyway. There is a test added that includes plandoing every single entrance to a shop.
This PR partially contains #3658 because the merge would be awful.How was this tested?
Many test gens, some test games, unit tests.
If this makes graphical changes, please attach screenshots.
N/A