Core, ALTTP: Plando (#2904) fixes #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: bug/fix
|
Maybe it's out of scope, but maybe you could also fix the broken link here https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/alttp/docs/plando_en.md?plain=1#L159 Edit: I opened a separate PR where it would at least be a lot more in-scope |
Exempt-Medic
added
the
waiting-on: world-maintainer
Exempt-Medic
approved these changes
Aug 23, 2024
beauxq
reviewed
Aug 23, 2024
Exempt-Medic
added
the
waiting-on: author
alwaysintreble
removed
the
waiting-on: author
Berserker66
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixing 2 issues that arose out of #2904.
Plando texts apparently supported weighting
atandtext, with the only documentation for such a feature being the ALTTP plando docs. This restores that feature.Additionally, LttP Plando Connections were broken by my own misunderstanding of valid exit names for ALttP (it shares the same entrance and exit names).
How was this tested?
Generated LttP with the example plandos on the LttP Plando Guide, confirmed they worked as expected in game. Also generated with a plando connection that worked on 0.4.6, but caused failures on 0.5.0.
If this makes graphical changes, please attach screenshots.