Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myself as a world maintainer for DS3 #3882

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add myself as a world maintainer for DS3 #3882

merged 1 commit into from
Sep 11, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 5, 2024

I've already discussed this with @Marechal-L and gotten his approval.

@nex3
Add myself as a world maintainer for DS3
6f5f5c2 
I've already discussed this with @Marechal-L and gotten his approval.
@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 5, 2024
Jarno458
Jarno458 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Jarno458 Jarno458 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nothing wrong with the syntax so i guess this is fine

@NewSoupVi NewSoupVi added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Sep 5, 2024
@NewSoupVi NewSoupVi requested a review from Marechal-L September 5, 2024 09:10
@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 5, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving this my approval so I can remove the peer-review label really. I do approve it as well, obviously

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Sep 7, 2024
@NewSoupVi NewSoupVi merged commit 7621889 into ArchipelagoMW:main Sep 11, 2024
3 checks passed
@nex3 nex3 deleted the patch-1 branch September 11, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Marechal-L Marechal-L Marechal-L approved these changes

@Jarno458 Jarno458 Jarno458 approved these changes

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nex3 @Jarno458 @Marechal-L @NewSoupVi @Exempt-Medic