Core: fix pickling plando connections #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
added
is: bug/fix
qwint
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
found someone's tunic yaml with some plando connections, confirmed it failed to generate on 24242, confirmed it generated (and the plando connections were honored) on localhost of this branch
did not really code review (it looks simple enough but I'm not comfortable with that section of utils)
Exempt-Medic
added
the
waiting-on: author
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
Exempt-Medic
approved these changes
Oct 19, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
PlandoConnection had a hack that allowed it to be pickled from
worlds.generic. #2904 moved PlandoConnection from worlds.generic to Options, so this hack had to be adjusted.How was this tested?
Ran Webhost locally and generated a Minecraft game featuring a plando connection
If this makes graphical changes, please attach screenshots.