Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio: Remove the need to have two separate installs #4221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silasary
Copy link
Contributor

I needed this to play nice with OSX's gatekeeper, because standalone mode doesn't work when the entire app gets checksummed.

What is this fixing or adding?

This allows the user to point AP at their regular Factorio binary, and instead sets the write-path with command line args.

This has a few benefits:

  • Easier to set up
  • Easier to keep Client/Server version in sync (They can be the same binary now)
  • Works on OSX with Gatekeeper enabled

I also added a check for when someone points the executable path at the .app bundle, rather than the correct value of /Applications/factorio.app/Contents/MacOS/factorio

How was this tested?

  • Tested on OSX 14.5 on Apple Silicon with executable set to /Applications/factorio.app
  • Tested on Windows 11 with the executable set to C:\Program Files\Factorio\bin\x64\factorio.exe
  • Tested on Windows 11 with the executable set to factorio\bin\x64\factorio.exe

Note: When on Windows, with an existing standalone install in factorio\bin\x64\factorio.exe, you cannot also run the Standalone from the same directory. This is intentional, as I picked that configuration's default write directory as the one AP uses.

If this makes graphical changes, please attach screenshots.

Needed this to play nice with OSX's gatekeeper, because standalone mode doesn't work when the entire app gets checksummed.
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 21, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Nov 21, 2024
@Alchav
Copy link
Contributor

Alchav commented Dec 8, 2024

The client was unable to create a new game while I had Factorio running. Seems the initial command to run Factorio to create the save file fails if the game is running. If I open the client for the first time without the game running, then it works and then I can open them in any order and they work as advertised. I'm running Ubuntu.

@silasary
Copy link
Contributor Author

silasary commented Dec 9, 2024

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants