Stardew Valley: Force deactivation of Mr. Qi's special orders when ginger island is deactivated #4348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This force the deactivation of Mr. Qi's special orders when ginger island is deactivated. Not force disabling this option was not a bug, because every time we check if Qi's special orders were enabled, we also check if ginger island is enabled (now this is unnecessary). The goal is more to handle incompatible option combination at the same place and log a warning to the person generating knows that some locations won't be included. This will also prevent future bug if we eventually forgot to check ginger island every time we also check if Qi's special orders are enabled.
How was this tested?
If this makes graphical changes, please attach screenshots.
N/A