Stardew Valley: Move test option presets to their own file #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: refactor/cleanup
agilbert1412
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I'm often getting circular dependencies issues because stuff is getting relative imported from the parent module, but the parent module also imports other stuff... That mostly happen with the stardew world module, but anyway, it seems like a healthy thing to do to move related stuff in a separated module.
How was this tested?
Yes
I just PyCharm bulk moved the function and cleaned up some imports, so nothing should have changed. The tests pass.
If this makes graphical changes, please attach screenshots.
N/A