LADX: Closing the client window closes the window #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
threeandthreee
approved these changes
Dec 9, 2024
Exempt-Medic
added
the
is: bug/fix
ScipioWright
approved these changes
Dec 24, 2024
ScipioWright
added
waiting-on: core-review
black-sliver
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The bug is the following: if you launch the ladx client, connect to the server then attempt to close without connecting the client to retroarch/bizhawk, the client will just hang.
I put a bandaid there so that it stopped happening since it has been at least a year since I submitted this bug report. A proper sync like the other clients would be cleaner in the future
How was this tested?
By opening, connecting then closing
If this makes graphical changes, please attach screenshots.
Before:
After: