Core: cast all the settings values so they don't try to get pickled later #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
|
Despite me having a "competing" PR open, I think this is also a fine solution to the issue and would be happy for it to be merged instead, or both to be merged |
NewSoupVi
added
the
is: bug/fix
Berserker66
approved these changes
Dec 12, 2024
|
I'm in favor of this one. Adding more stuff to the unpickler is security relevant, something to look out for. Whereas this avoids that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
cast all the settings values so they don't try to get pickled later
How was this tested?
ran webhost with forcing the
elif len(gen_options) >= app.config["JOB_THRESHOLD"]:line to resolve false to trigger the else clause and didn't see unpickling errorsIf this makes graphical changes, please attach screenshots.