-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network: implement 0.4 marked compatibility removals #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless I get a lot of green lights quite soon, my intention is to merge this after our next release. |
Jarno458
added a commit
to ArchipelagoMW/Archipelago.MultiClient.Net
that referenced
this pull request
Jul 8, 2022
Proposed changes to AP: ArchipelagoMW/Archipelago#757
Jarno458
added a commit
to ArchipelagoMW/Archipelago.MultiClient.Net
that referenced
this pull request
Jul 15, 2022
* Throw TimeoutException if accidentally caught in infinite loop when retrieving from DataStorage. * Fix for .net client failing to connect in AP 0.4 Proposed changes to AP: ArchipelagoMW/Archipelago#757 * Added unit test + refactored Co-authored-by: Hussein Farran <hmfarran@gmail.com>
36 tasks
apclientpp ✔️
|
apcpp ✔️
|
black-sliver
added
meta: help wanted
Additional review/assistance is requested for these issues or pull requests.
affects: core
Issues/PRs that touch core and may need additional validation.
labels
Jul 28, 2022
# Conflicts: # MultiServer.py # SNIClient.py # worlds/smz3/__init__.py # worlds/soe/__init__.py
Berserker66
commented
Sep 27, 2022
Berserker66
commented
Sep 27, 2022
# Conflicts: # SNIClient.py # worlds/__init__.py # worlds/soe/__init__.py
black-sliver
approved these changes
Dec 11, 2022
LiquidCat64
pushed a commit
to LiquidCat64/LiquidCatipelago
that referenced
this pull request
Dec 12, 2022
* world remote items handling * players list when connecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: core
Issues/PRs that touch core and may need additional validation.
meta: help wanted
Additional review/assistance is requested for these issues or pull requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should all have been documented at least a month ago. People testing their clients would be appreciated. The python clients should all be fine, even 0.3.3 clients worked in my testing, though they will say "No player connected". - But again, additional testing won't hurt.