Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: implement 0.4 marked compatibility removals #757

Merged
merged 12 commits into from
Dec 11, 2022

Conversation

Berserker66
Copy link
Member

These changes should all have been documented at least a month ago. People testing their clients would be appreciated. The python clients should all be fine, even 0.3.3 clients worked in my testing, though they will say "No player connected". - But again, additional testing won't hurt.

@Berserker66 Berserker66 marked this pull request as draft July 8, 2022 01:30
@Berserker66
Copy link
Member Author

Berserker66 commented Jul 8, 2022

Unless I get a lot of green lights quite soon, my intention is to merge this after our next release.

Jarno458 added a commit to ArchipelagoMW/Archipelago.MultiClient.Net that referenced this pull request Jul 8, 2022
Jarno458 added a commit to ArchipelagoMW/Archipelago.MultiClient.Net that referenced this pull request Jul 15, 2022
* Throw TimeoutException if accidentally caught in infinite loop when retrieving from DataStorage.

* Fix for .net client failing to connect in AP 0.4
Proposed changes to AP: ArchipelagoMW/Archipelago#757

* Added unit test + refactored

Co-authored-by: Hussein Farran <hmfarran@gmail.com>
@black-sliver
Copy link
Member

black-sliver commented Jul 22, 2022

apclientpp ✔️

  • games are a set since version 0.2.6; never used the index
  • GetDataPackage["games"] since 0.2.6
  • items_handling since 0.2.0
  • never supported datapackage_version (the single int)

@black-sliver
Copy link
Member

black-sliver commented Jul 22, 2022

apcpp ✔️

  • does not seem to use RoomInfo["games"]
  • items_handling is being sent since 0.2.2
  • datapackage_version would become always 0, but caching is currently not implemented afaik
  • uses neither exclusions nor games in GetDataPackage

@black-sliver black-sliver added meta: help wanted Additional review/assistance is requested for these issues or pull requests. affects: core Issues/PRs that touch core and may need additional validation. labels Jul 28, 2022
Berserker66 and others added 2 commits August 11, 2022 00:53
# Conflicts:
#	MultiServer.py
#	SNIClient.py
#	worlds/smz3/__init__.py
#	worlds/soe/__init__.py
worlds/ff1/__init__.py Outdated Show resolved Hide resolved
worlds/ff1/__init__.py Outdated Show resolved Hide resolved
@Berserker66 Berserker66 marked this pull request as ready for review October 20, 2022 10:09
@Berserker66 Berserker66 merged commit 2cdd03f into main Dec 11, 2022
@Berserker66 Berserker66 deleted the network_compat_removal branch December 11, 2022 01:59
LiquidCat64 pushed a commit to LiquidCat64/LiquidCatipelago that referenced this pull request Dec 12, 2022
* world remote items handling
* players list when connecting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. meta: help wanted Additional review/assistance is requested for these issues or pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants