Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Refactor Autoworld.options to Autoworld.option_definitions #906

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Core: Refactor Autoworld.options to Autoworld.option_definitions #906

merged 5 commits into from
Aug 15, 2022

Conversation

alwaysintreble
Copy link
Collaborator

First step towards issue #839 that can be done before the full system move and would like to get in ASAP

@black-sliver black-sliver added the is: enhancement Issues requesting new features or pull requests implementing new features. label Aug 15, 2022
@Jarno458
Copy link
Collaborator

Seems like a straid up rename so should be save to merge

black-sliver
black-sliver requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and update references to .options in docs/, specifically world api.md, but i think adding games.md may also reference it.

black-sliver
black-sliver approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled couple of seeds and did a quick ctrl+f and looks like you found all references.

@black-sliver black-sliver merged commit 81cf150 into ArchipelagoMW:main Aug 15, 2022
@alwaysintreble alwaysintreble deleted the option_definitions branch November 1, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwaysintreble @Jarno458 @black-sliver