-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Data Binding on Characters Activity #37
delete charactersUiModel because implemented databinding. Create diferent bindingAdapter for use in xml. Create Event for use navigation. javier.mcardona@gmail.com
- Loading branch information
Showing
12 changed files
with
218 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersBindingAdapters.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.architect.coders.mu8.characters | ||
|
|
||
| import androidx.databinding.BindingAdapter | ||
| import androidx.recyclerview.widget.RecyclerView | ||
| import com.architect.codes.mu8.characters.Character | ||
|
|
||
| @BindingAdapter("items") | ||
| fun RecyclerView.setItems(characters: List<Character>?) { | ||
| (adapter as? CharactersAdapter)?.let { | ||
| it.characters = characters ?: emptyList() | ||
| } | ||
| } |
9 changes: 0 additions & 9 deletions
9
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersUiModel.kt
This file was deleted.
Oops, something went wrong.
31 changes: 22 additions & 9 deletions
31
presentation/src/main/java/com/architect/coders/mu8/characters/CharactersViewModel.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,40 @@ | ||
| package com.architect.coders.mu8.characters | ||
|
|
||
| import android.view.View | ||
| import android.view.View.GONE | ||
| import android.view.View.VISIBLE | ||
| import androidx.lifecycle.LiveData | ||
| import androidx.lifecycle.MutableLiveData | ||
| import com.architect.coders.mu8.utils.Event | ||
| import com.architect.coders.mu8.utils.ScopedViewModel | ||
| import com.architect.codes.mu8.characters.Character | ||
| import com.architect.codes.mu8.characters.CharactersUseCase | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class CharactersViewModel(private val charactersUseCase: CharactersUseCase) : ScopedViewModel() { | ||
|
|
||
| private val _model = MutableLiveData<CharactersUiModel>() | ||
| val model: LiveData<CharactersUiModel> | ||
| get() { | ||
| if (_model.value == null) getCharacters() | ||
| return _model | ||
| } | ||
| private val _navigateToCharacter = MutableLiveData<Event<Long>>() | ||
| val navigateToCharacter: LiveData<Event<Long>> get() = _navigateToCharacter | ||
|
|
||
| private val _loading = MutableLiveData<Boolean>() | ||
| val loading: LiveData<Boolean> get() = _loading | ||
|
|
||
| private val _characters = MutableLiveData<List<Character>>() | ||
| val characters: LiveData<List<Character>> get() = _characters | ||
|
|
||
| init { | ||
| getCharacters() | ||
| } | ||
|
|
||
| private fun getCharacters() { | ||
| launch { | ||
| _model.value = CharactersUiModel.Loading | ||
| _model.value = CharactersUiModel.Content(charactersUseCase()) | ||
| _loading.value = true | ||
| _characters.value = charactersUseCase() | ||
| _loading.value = false | ||
| } | ||
| } | ||
|
|
||
| fun onCharacterClicked(character: Character) = Unit | ||
| fun onCharacterClicked(character: Character) { | ||
| _navigateToCharacter.value = Event(character.id) | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
presentation/src/main/java/com/architect/coders/mu8/utils/BindingAdapters.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.architect.coders.mu8.utils | ||
|
|
||
| import android.view.View | ||
| import androidx.databinding.BindingAdapter | ||
|
|
||
| @BindingAdapter("visible") | ||
| fun View.setVisible(visible: Boolean?) { | ||
| visibility = visible?.let { | ||
| if (visible) View.VISIBLE else View.GONE | ||
| } ?: View.GONE | ||
| } |
44 changes: 44 additions & 0 deletions
44
presentation/src/main/java/com/architect/coders/mu8/utils/Event.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package com.architect.coders.mu8.utils | ||
|
|
||
| import androidx.lifecycle.Observer | ||
|
|
||
| /** | ||
| * Used as a wrapper for data that is exposed via a LiveData that represents an event. | ||
| * Taken from: https://medium.com/androiddevelopers/livedata-with-snackbar-navigation-and-other-events-the-singleliveevent-case-ac2622673150 | ||
| */ | ||
| open class Event<out T>(private val content: T) { | ||
|
|
||
| var hasBeenHandled = false | ||
| private set // Allow external read but not write | ||
|
|
||
| /** | ||
| * Returns the content and prevents its use again. | ||
| */ | ||
| fun getContentIfNotHandled(): T? { | ||
| return if (hasBeenHandled) { | ||
| null | ||
| } else { | ||
| hasBeenHandled = true | ||
| content | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns the content, even if it's already been handled. | ||
| */ | ||
| fun peekContent(): T = content | ||
| } | ||
|
|
||
| /** | ||
| * An [Observer] for [Event]s, simplifying the pattern of checking if the [Event]'s content has | ||
| * already been handled. | ||
| * | ||
| * [onEventUnhandledContent] is *only* called if the [Event]'s contents has not been handled. | ||
| */ | ||
| class EventObserver<T>(private val onEventUnhandledContent: (T) -> Unit) : Observer<Event<T>> { | ||
| override fun onChanged(event: Event<T>?) { | ||
| event?.getContentIfNotHandled()?.let { value -> | ||
| onEventUnhandledContent(value) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,40 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| <layout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| tools:context=".categories.CategoriesActivity"> | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
|
|
||
| <include | ||
| android:id="@+id/toolbar" | ||
| layout="@layout/toolbar" /> | ||
| <data> | ||
| <variable | ||
| name="viewmodel" | ||
| type="com.architect.coders.mu8.characters.CharactersViewModel" /> | ||
| </data> | ||
|
|
||
| <ProgressBar | ||
| android:id="@+id/progress" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/toolbar" /> | ||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| tools:context=".categories.CategoriesActivity"> | ||
|
|
||
| <androidx.recyclerview.widget.RecyclerView | ||
| android:id="@+id/recycler" | ||
| android:layout_width="@dimen/match_constraint" | ||
| android:layout_height="@dimen/match_constraint" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/toolbar" /> | ||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| <include | ||
| android:id="@+id/toolbar" | ||
| layout="@layout/toolbar" /> | ||
|
|
||
| <ProgressBar | ||
| android:id="@+id/progress" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| app:visible="@{viewmodel.loading}" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/toolbar" /> | ||
|
|
||
| <androidx.recyclerview.widget.RecyclerView | ||
| android:id="@+id/recycler" | ||
| android:layout_width="@dimen/match_constraint" | ||
| android:layout_height="@dimen/match_constraint" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/toolbar"/> | ||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| </layout> |
Oops, something went wrong.