Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #31: Create Room Database & Issue #33: Save Characters from the service to the Database #35

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Issue #31: Create Room Database & Issue #33: Save Characters from the service to the Database #35

merged 1 commit into from
Dec 31, 2019

Conversation

recaldev
Copy link
Collaborator

@recaldev recaldev commented Dec 27, 2019 •
edited
Loading

What's in:

  • Initial setup for room library.
  • Fixed tech debt on Categories Activity.
  • Added entity, DAO and implementation to get Characters from the database if they are already cached from the service.

Testing Done:

  • On real device: Pixel 2 XL.

How it looks: http://bit.ly/2srCrIL

How to test:

  • Run the app and reach the main screen.
  • Tap on the Characters category to enter the screen.
  • Notice the delay while the app is downloading 100 characters.
  • Get back to the Main Screen after it has loaded and enter again to the Characters Screen, notice how fast it is the load now that we're getting the info from the database.

Signed-off-by:

@recaldev @difereto-globant
Issue #31: Create Room Database.
1b751ca 
Issue #33: Save Characters from the service to the Database.

- Initial setup for room library.
- Added entity, DAO and implementation to get Characters from the database if they are already cached from the service.

Signed-off-by: Diego Recalde <diego.recalde@globant.com>
@recaldev recaldev added the enhancement New feature or request label Dec 27, 2019
@recaldev recaldev added this to the Cache Strategy with Room milestone Dec 27, 2019
aliceresponde
aliceresponde approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@aliceresponde aliceresponde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jamacado jamacado merged commit 920735e into development-mu8 Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliceresponde aliceresponde aliceresponde approved these changes

@SalosV SalosV Awaiting requested review from SalosV

@jamacado jamacado Awaiting requested review from jamacado

Assignees

@aliceresponde aliceresponde

@jamacado jamacado

@SalosV SalosV

Labels
enhancement New feature or request
Projects
None yet
Milestone
Cache Strategy with Room
Development

Successfully merging this pull request may close these issues.
4 participants
@recaldev @aliceresponde @jamacado @SalosV