Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #48: Use Navigation Component #51

Open
wants to merge 3 commits into
base: development-mu8
Choose a base branch
from

Conversation

recaldev
Copy link
Collaborator

@recaldev recaldev commented Jan 26, 2020

What's in:

  • Updated version for ship stats service to v3.

Testing Done:

  • On real device: Pixel 2 XL.

How it looks:

MU8NavComponent

How to test:

  • Launch the app and navigate through it.
  • Check the new navigation using the navigation components from JetPack.
  • Check that there is no error on any of the screens already implemented.

Signed-off-by:

…he Categories Screen.

- Added dependencies for Navigation Component with Safe Args.
- Added Navigation Component for current Activities.

Signed-off-by: Diego Recalde <difereto89@gmail.com>
# Conflicts:
#	presentation/src/main/java/com/architect/coders/mu8/categories/CategoriesActivity.kt
#	presentation/src/main/java/com/architect/coders/mu8/characters/CharactersActivity.kt
#	presentation/src/main/res/values/strings.xml
…he Categories Screen.

- Added Navigation Component for Event Activity.
- Created approach for back navigation.

Signed-off-by: Diego Recalde <difereto89@gmail.com>
@recaldev recaldev added the enhancement New feature or request label Jan 26, 2020
@recaldev recaldev added this to the Navigation Component milestone Jan 26, 2020
@recaldev recaldev changed the title Issue # 48: Use Navigation Component Issue #48: Use Navigation Component Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants