updeted to support django 1.6 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accidentally passed a list of models in without *ing them. When that happens, we get a string formatting exception (not all arguments were formatted) instead of the useful "that ain't a model, kid" business.
Means that including a boost field in a document will cause document level boosting.
pks_seen is only needed if objects are removed from index, so only compute it if necessary. Improve pks_seen to not build an intermediary list.
To my knowledge, the 'HAYSTACK_EXCLUDED_INDEXES' setting is no longer used.
Updated description for TIMEOUT setting - thanks @pabluk
What's left are 3 failures, all ordering issues, where the correct output is present, but ordering is different between Py2 / Py3.
Requires git master (ES 1.0.0 beta) to work properly when using suggestions.
Allow for document boosting with elasticsearch
Update autocomplete.rst
Each narrow query will be cached individually which means more cache reuse
- don't specify defaults (index:analyzed for strings, boost: 1.0) - omit extra settings that have little or negative effects (term_vector:with_positions_offsets) - only use type-specific settings (not_analyzed makes no sense for non-string types) Fixes django-haystack#866
This allows customization by subclasses and also fixes django-haystack#888 by ensuring that the custom field list prepared by `ValuesQuerySet` and `ValuesListQuerySet` is actually used.
…kend This allows customization by subclasses and also fixes django-haystack#888 by ensuring that the custom field list prepared by `ValuesQuerySet` and `ValuesListQuerySet` is actually used.
That will justlead to fields being stored once - as part of _source as well as in separate index that would never be used by haystack (would be used only in special cases when requesting just that field, which can be, with minimal overhead, still just extracted from the _source as it is).
Until pysolr 3.1.1 ships there's no point in running the Solr content extraction tests because they'll fail: django-haystack/pysolr#104
…-regression Solr / ElasticSearch backends: restore run() kwargs handling This fixes an earlier regression which did not break functionality but made `.values()` and `.values_list()` much less of an optimization than intended. django-haystack#925 will be a more comprehensive refactor but this is enough of a performance win to be worth including if a point release happens before django-haystack#925 lands.
3.1.1 shipped a fix for a change in the Solr response format for the content extraction handler
* Django 1.4 is no longer supported as per the documentation * Travis: use Python 3.3 targets instead of 3.2
404 in indices.delete can only mean that the index is there, no issue for a delete operation Fixes django-haystack#647
We use HAYSTACK_ID_FIELD in other places but the value passed to pysolr's delete() method must use the keyword argument ``id``: https://github.com/toastdriven/pysolr/blob/v3.1.0/pysolr.py#L756 Although the value is passed to Solr an XML tag named ``<id>`` it will always be checked against the actual ``uniqueKey`` field even if it uses a custom name: https://wiki.apache.org/solr/UpdateXmlMessages#A.22delete.22_documents_by_ID_and_by_Query Closes django-haystack#943
Small docs fix for spatial search example code
This was used in an except: handler and would only be executed when a load_all() queryset retrieved a model which wasn't registered with the index.
Update tutorial.rst
Fix possessive "its" in tutorial.rst
Fix typo; clarify purpose of search template
Improve punctuation in super-scary YMMV warning
It was possible to get a KeyError when spelling suggestions were requested but no suggestions are returned by the backend. Thanks to Steven Skoczen (@skoczen) for the patch
On Django 1.7, `Options.module_name` was deprecated in favor of `model_name`. This commit corrects files for this versions of Django.
Conflicts: haystack/backends/__init__.py haystack/backends/elasticsearch_backend.py haystack/backends/simple_backend.py haystack/backends/solr_backend.py haystack/backends/whoosh_backend.py haystack/query.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.