This repository has been archived by the owner on May 30, 2018. It is now read-only.
Added support for Corsair devices and compiled with newer Logitech SDK #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty cool! I can't test the Corsair support myself, so I'll assume it works correctly. Regarding your added feature, I guess it's okay to have it there as long it's optional, which it is. I haven't worked on this for quite a while now (and also not used it since it's not working on the 64-bit client of Guild Wars 2, sadly enough), so I'll have to re-initialize my development environment before merging this. Thanks for your effort! |
Archomeda
added a commit
that referenced
this pull request
Dec 19, 2015
Added support for Corsair devices and compiled with newer Logitech SDK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as adding support for corsair, I have also added a small feature for myself to restore the lighting on keyboard when all passed values are 0. Effectively when everything is off, it will restore the saved configuration. Only added to the Logitech devices.