Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #211 #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #211 #317

wants to merge 1 commit into from

Conversation

Intybyte
Copy link
Contributor

Fixes #211

This is an hotfix, basically what hapened is that leaves of spruces can be up to 300 in size, bigger than the whole trunk, to fix this now the treecapitator will count logs and leaves separately, I suggest to get the maxTrunkBroken and maxLeavesBroken from a file instead of the current approach of hardcoding them.

@Archy-X
Copy link
Owner

Archy-X commented Sep 27, 2024

The issue with this kind of fix is that if any adjacent trees are connected through leaves, it will break those before breaking the very top logs sometimes. And when I tested breaking normal spruce trees with connecting trees it breaks a lot more blocks than before, possibly making the ability too strong. Ideally, there should be some tree shape detection algorithmn so it only breaks one tree. Not expecting anyone to contribute that, but I'll probably hold off on making changes to treecapitator until the algorithm gets recoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with mana ability treecapitator
2 participants