Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Six new icons for some apps #2237

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Six new icons for some apps #2237

merged 4 commits into from
Sep 17, 2024

Conversation

GitEnte
Copy link
Contributor

@GitEnte GitEnte commented Aug 5, 2024

Apps that have new icons are:
WDR aktuell, 360° online, Andor, Mutti-App, TK Husteblume

This is my first time making and adding icons btw, so it should defenitily be checked before merging :).

Apps that have new icons are:
WDR aktuell, 360° online, Andor, Mutti-App, TK Husteblume

This is my first time making and adding icons btw.
@GitEnte GitEnte changed the title New icons for some apps Six new icons for some apps Aug 5, 2024
@Donnnno
Copy link
Collaborator

Donnnno commented Aug 5, 2024

Hi, congrats on your first contribution!
We need to change some things, as in its current stage I can't merge them!

  • we only use lines, looks like you used lines and rectangular shapes. Also the line-width is inconsistent here
    image

That applies here as well
image

Also, please use the SVG font from the template folder, instead of the otf typeface

image

Please check our contribution guide carefully: https://docs.arcticons.com/contribute/creating-icons

I tried to fix the issues with consistency. Im not sure about the dots though. I also changed the color of every line to white to follow the guidelines.
@GitEnte
Copy link
Contributor Author

GitEnte commented Aug 5, 2024

Screenshot 2024-08-05 133302
Screenshot 2024-08-05 133845
I noticed that some of the lines in the letters 0 and R stand out in weird and out of place ways. Is this intentional?

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 5, 2024

Oh that's a bug, I'll take a look at it!

@GitEnte
Copy link
Contributor Author

GitEnte commented Aug 7, 2024

Does anything need further changing?

Donnnno and others added 2 commits September 17, 2024 17:03
Co-Authored-By: GitEnte <128993832+gitente@users.noreply.github.com>
Co-Authored-By: GitEnte <128993832+gitente@users.noreply.github.com>
@Donnnno
Copy link
Collaborator

Donnnno commented Sep 17, 2024

Great work!

@Donnnno Donnnno merged commit 325e5af into Arcticons-Team:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants