Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the blocked texts on the license page #275

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

EasyVector
Copy link
Contributor

Dear developer:

Hello! I am the creator of this pull request: dkanada/frost#502 , and I have fixed the same problem for this app. I would appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!

Here is the screenshot after my changes:

copy

Thanks again! :)

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

Hi, thanks for the fix!

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

Hmm, it changes the minimum API from 16 to 26 tho :s

@EasyVector
Copy link
Contributor Author

Well, it appears so. I will keep looking for some way to eliminate this problem.

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

Ehh, still is possible because it's a minimum of android 8 then.

But maybe it should be an optional thing for 26 and up, if that's possible?

@EasyVector
Copy link
Contributor Author

EasyVector commented Aug 27, 2021

I just found out we can apply this code, namely changing this code:

textView.setAutoSizeTextTypeWithDefaults(TextView.AUTO_SIZE_TEXT_TYPE_UNIFORM);

to the following:

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
     textView.setAutoSizeTextTypeWithDefaults(TextView.AUTO_SIZE_TEXT_TYPE_UNIFORM);
}

With this if-statement, Android could know which API this code suits for. Would that be apt?

@EasyVector
Copy link
Contributor Author

If you agree with this code I would like to push another commit. :) Thanks!

@EasyVector
Copy link
Contributor Author

But maybe it should be an optional thing for 26 and up, if that's possible?

Sorry I missed this one. I truly did some dig, and I found out this code is suitable for API 26 and higher. It is a new feature.

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

Great!

@EasyVector
Copy link
Contributor Author

OK! I will edit this code later. :)
Thank you so much!

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

No, thank you for making the app more accessible! :^)

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 27, 2021

Tested it and it works perfect now, without errors :)

@Donnnno Donnnno merged commit 363468b into Arcticons-Team:main Aug 27, 2021
@EasyVector
Copy link
Contributor Author

OK! That‘s wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants