Make tables pretty #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, before in the schedule tab there were two separate classes 'matchNumber' and 'lastRedTeam' that had a 1px solid border applied to on the right to denote a division. Now, that functionality is replaced by a 'divider' class; however, 'matchNumber' is still a class because it might prove useful later - it doesn't have any styles right now.
I apply a 'redTeam' and 'blueTeam' class to the td's that store a red or blue team, respectively. Colours for red and blue are then in HSLA format, which allow the opacity to be changed for alternating rows and which allow the hue to be changed to create similar shades of red and blue.
By using a new class, bottomDivider, we are able to draw a line between
red and blue teams. To apply this class, we use more inline logic with
` and ${} (might change this later to be more readable).
Currently, there is no input to actually search a team. There are also some hacky things going on here, particularly with the nested ternary operators in defining classes and the usage of !important to override the more specific "odd row" selector. We might want to look into better ways to do each of these.
moeezm
force-pushed
the
pretty-tables
branch
from
35a15e6
to
1ff9c52
Compare
Constrast between text and background was too low to be comfortable
michal-davis
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bunch of stuff. Requesting to merge so I can do code cleanup on the whole base by branching off of webapp. I recommend keeping this branch open if anyone else wants to do other stylizing stuff.