Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - search agent curatorial remark #6699

Closed
Jegelewicz opened this issue Aug 31, 2023 · 10 comments
Closed

Feature Request - search agent curatorial remark #6699

Jegelewicz opened this issue Aug 31, 2023 · 10 comments
Labels
Enhancement I think this would make Arctos even awesomer! Function-Agents Priority-High (Needed for work) High because this is causing a delay in important collection work..

Comments

@Jegelewicz
Copy link
Member

Issue Documentation is http://handbook.arctosdb.org/how_to/How-to-Use-Issues-in-Arctos.html

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

We added curatorial remark to agents, but there is no way to search it.

Describe what you're trying to accomplish
A clear and concise overview of the goals; why are you asking for this?

Find an agent based upon information placed in curatorial remark

Describe the solution you'd like
How might we accomplish your goals?

add the field to the search form

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

not finding stuff, asking for SQL

Additional context
Add any other context or screenshots about the feature request here.

Priority
Please assign a priority-label. Unprioritized issues gets sent into a black hole of despair.

Agent data has been added for an incoming collection that will want to find things using this information. Inability to do this makes data migration more difficult.

@Jegelewicz Jegelewicz added Priority-High (Needed for work) High because this is causing a delay in important collection work.. Function-Agents Enhancement I think this would make Arctos even awesomer! labels Aug 31, 2023
@Jegelewicz Jegelewicz added this to the Needs Discussion milestone Aug 31, 2023
@AJLinn
Copy link

AJLinn commented Aug 31, 2023

Yes please.

@Jegelewicz
Copy link
Member Author

@dustymc I really need this to help me work through some agents for an incoming collection. How hard is it to add this search field?

@dustymc
Copy link
Contributor

dustymc commented Sep 18, 2023

Not difficult (has that ever been the limitation?!) but still needs to go through the process (https://github.com/ArctosDB/internal/issues/258), gappy though it may be. (And if you can somehow ram that through now-ish, I'm at a point where I could start working on this...)

Ideally I think this would be combined with #6645 - the searching would likely be much more productive if seeing the results wasn't a couple clicks away.

(And that might reuse the pick format, which also doesn't contain curatorial remarks...)

@Jegelewicz
Copy link
Member Author

Honestly - I don't think #6645 is needed, but I'll let others weigh in.

@ArctosDB/arctos-working-group-officers thoughts on getting this to implementation?

@campmlc
Copy link

campmlc commented Sep 18, 2023

I support implementing this. I'm not sure #6645 is needed either - especially since it would return far fewer results at a time without scrolling down. Maybe if the interface were cleaned up a bit. But that shouldn't stop #6699.

@AJLinn
Copy link

AJLinn commented Sep 18, 2023

I'm not an officer, and agreed that this would be useful above, so I'll just reiterate my support that the curatorial remarks field would be useful for searching.

@dustymc
Copy link
Contributor

dustymc commented Sep 19, 2023

not an officer

At least from my perspective, that isn't required (or desired, unless it's their personal Issue - things are about always more clear when the actual user is involved).

  1. I need to know that I've got the scope right (below).
  2. I need to know that nobody thinks this is a terrible idea (somehow acknowledge the below and the summary will get moved to dev, where hopefully everyone's got their notifications set up).
  3. I think we need to do a lot better on priority (there are certainly one-user things that need built, but probably only after the 19-user things are addressed).

I think maybe that's it? The only real need for officers is if something gets stuck somewhere, when they can swoop in and un-stick it. (And maybe that introduces (0), "I need to know this is actionable" - wonder if that's our biggest bottleneck?)

ANYWAY - somehow let me know if I've got the below correct.


Source

#6699

Summary

Add curatorial remarks as a search term to manage agents.

User Interface Changes

New search option in manage agents.

Data Structure Changes

None.

@Jegelewicz
Copy link
Member Author

To be very clear - we are asking to add that to the "manage" search
image

NOT the public search
image

which are indistinguishable by their web address

@dustymc
Copy link
Contributor

dustymc commented Sep 19, 2023

very clear

Screenshot 2023-09-19 at 07 59 00

How could I have been more clear? (Because whatever goes to dev should not leave anyone guessing!)

indistinguishable

https://arctos.database.museum/agent.cfm
https://arctos.database.museum/agents.cfm

... except for the different letters. :)

@Jegelewicz
Copy link
Member Author

except for the different letters. :)

yeah - that's a pretty small difference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement I think this would make Arctos even awesomer! Function-Agents Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

4 participants