Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reintegrate username functionality #1101

Open
wants to merge 20 commits into
base: mainsail-develop
Choose a base branch
from

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Dec 18, 2024

Summary

https://app.clickup.com/t/86dvdmpme

Mostly reverting username removals from #1000

TODO:

  • Add tests
  • PHPStan
  • Review the below files for username first, known first, or enforce one of the two - I set them up with the same functionality as previously

  • resources/scripts/vote-report.sh - add username?
  • resources/views/app/wallet.blade.php - prioritize username or known name?
  • resources/views/components/general/identity-iconless.blade.php - prioritize username or known name?
  • resources/views/components/stats/insights/desktop/validator-row.blade.php - prioritize username or known name?
  • resources/views/components/stats/insights/mobile/validator-row.blade.php - prioritize username or known name?

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley mentioned this pull request Jan 6, 2025
9 tasks
@alexbarnsley alexbarnsley changed the title [WIP] feat: reintegrate username functionality feat: reintegrate username functionality Jan 15, 2025
@alexbarnsley alexbarnsley marked this pull request as ready for review January 15, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant