refactor: disable signature requirement for refresh actions (#314)

ArdentHQ · Oct 31, 2023 · 13e87ff · 13e87ff
1 parent 0dec26e
commit 13e87ff
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 18 deletions.
diff --git a/resources/js/Pages/Collections/Components/CollectionsHeading/RefreshButton.tsx b/resources/js/Pages/Collections/Components/CollectionsHeading/RefreshButton.tsx
@@ -7,22 +7,18 @@ import { useToasts } from "@/Hooks/useToasts";
 import { isTruthy } from "@/Utils/is-truthy";
 
 export const RefreshButton = ({ wallet }: { wallet: App.Data.Wallet.WalletData | null }): JSX.Element => {
-    const [loading, setLoading] = useState(false);
     const [disabled, setDisabled] = useState(false);
     const { t } = useTranslation();
 
-    const { signedAction } = useAuthorizedAction();
+    const { authenticatedAction } = useAuthorizedAction();
     const { showToast } = useToasts();
 
     const refresh = (): void => {
-        void signedAction(async () => {
-            setLoading(true);
-
-            await window.axios.post(route("refresh-collections"));
-
-            setLoading(false);
+        void authenticatedAction((): void => {
             setDisabled(true);
 
+            void window.axios.post(route("refresh-collections"));
+
             showToast({
                 type: "pending",
                 message: t("pages.collections.refresh.toast"),
@@ -60,7 +56,6 @@ export const RefreshButton = ({ wallet }: { wallet: App.Data.Wallet.WalletData |
                     disabled={
                         isTruthy(wallet?.isRefreshingCollections) ||
                         !isTruthy(wallet?.canRefreshCollections) ||
-                        loading ||
                         disabled
                     }
                     type="button"

diff --git a/resources/js/Pages/Collections/View.tsx b/resources/js/Pages/Collections/View.tsx
@@ -84,8 +84,8 @@ const CollectionsView = ({
 
     const [showCollectionFilterSlider, setShowCollectionFilterSlider] = useState(false);
     const { requestActivityUpdate } = useWalletActivity();
-    const { signedAction } = useAuthorizedAction();
 
+    const { authenticatedAction } = useAuthorizedAction();
     const { showToast } = useToasts();
 
     const hasSelectedTraits = useMemo(
@@ -266,7 +266,7 @@ const CollectionsView = ({
     };
 
     const handleRefreshActivity = (): void => {
-        void signedAction(async () => {
+        void authenticatedAction((): void => {
             setIsLoadingActivity(true);
             requestActivityUpdate(collection.address);
 
@@ -275,7 +275,7 @@ const CollectionsView = ({
                 isExpanded: true,
             });
 
-            await axios.post<{ success: boolean }>(
+            void axios.post(
                 route("collection.refresh-activity", {
                     collection: collection.slug,
                 }),

diff --git a/routes/api.php b/routes/api.php
@@ -24,9 +24,7 @@
     Route::get('/tokens/breakdown', [Controllers\TokenController::class, 'breakdown'])->name('tokens.breakdown');
     Route::get('/tokens/search', [Controllers\TokenController::class, 'searchTokens'])->name('tokens.search');
 
-    Route::post('/refreshed-collections', [Controllers\RefreshedCollectionController::class, 'store'])
-            ->name('refresh-collections')
-            ->middleware('signed_wallet');
+    Route::post('/refreshed-collections', [Controllers\RefreshedCollectionController::class, 'store'])->name('refresh-collections');
 
     Route::post('/transaction-success', Controllers\TransactionSuccessController::class)
             ->name('transaction-success');

diff --git a/tests/App/Http/Controllers/RefreshedCollectionControllerTest.php b/tests/App/Http/Controllers/RefreshedCollectionControllerTest.php
@@ -4,7 +4,6 @@
 
 use App\Jobs\RefreshWalletCollections;
 use App\Models\Nft;
-use App\Support\Facades\Signature;
 use Illuminate\Support\Facades\Bus;
 
 it('can dispatch jobs to refresh all collections for a wallet', function () {
@@ -15,8 +14,6 @@
         'onboarded_at' => now(),
     ]);
 
-    Signature::setWalletIsSigned($user->wallet->id);
-
     Nft::factory()->for($user->wallet)->create();
     Nft::factory()->for($user->wallet)->create();