refactor: do not index NFTs for potentially "full" collections #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crnkovic
requested review from
samharperpittam and
boldninja
as code owners
ItsANameToo
requested changes
Sep 19, 2023
alfonsobries
approved these changes
Sep 27, 2023
patricio0312rev
approved these changes
Oct 4, 2023
shahin-hq
reviewed
Oct 4, 2023
| public function isPotentiallyFull(): bool | ||
| { | ||
| // If there is no supply or if the NFTs for the collection haven't been indexed, we know for sure it's not full... | ||
| if ($this->last_indexed_token_number === null || $this->supply === null) { |
There was a problem hiding this comment.
Please note that we are already filtering out collections with supply=null: https://app.clickup.com/t/85zu0hdha
It's worth double-checking to ensure that we are not excessively filtering out collections.
There was a problem hiding this comment.
wdym? we're filtering collections where the supply is not null so this check ($this->supply === null) will always be false and therefore irrelevant in this case
There was a problem hiding this comment.
with the current way we call this isPotentiallyFull method we won't ever pass it a collection with a null supply, but for reliability I'd keep the check in case something calls it without the withAcceptableSupply scope as it avoids assumptions here
alfonsobries
approved these changes
Oct 4, 2023
ItsANameToo
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/861nbbgp1
Checklist