-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: marketplace links in NFT details page #111
Conversation
I found an issue regarding collections like I think we can add an extra field to our DB to check if we should display or not that marketplace icon, however, this would require us to check each collection and see if they are working correctly. Another idea I have is to use our blacklist for some collections and just hide the marketplace icons for them. Attaching proof of this issue: Screen.Recording.2023-09-20.at.06.28.08.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patricio0312rev - quick on this PR.
The task states " In case there isn't that collection listed there we can assume NFT isn't either so in that case we hide that marketplace from the view."
Though, I'm looking at a collection called hwape_com
.
However, the collection doesn't exist on OpenSea or LooksRare as far as I can tell.
Is the logic for hiding marketplaces missing?
Other than that the PR looks nice
#138 depends on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important note: this requires to rerun the FetchCollectionsMetaData
job for existing collections, otherwise they will not show any marketplace details until the next time it triggers
can you have a look at the conflicts @patricio0312rev |
[nfts] Add marketplace links to NFTs
Summary
urls.php
.Marketplaces
component has been created, it supports the URL's fornfts
andcollections
.Screen.Recording.2023-09-25.at.11.52.08.mov
Steps to reproduce
test_e2e
mode. Make sure you have connected a wallet with collections for both ethereum and polygon./collections
page.Checklist