Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add msq articles to article seeder #148

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Sep 26, 2023

Summary

For the moment added all msq articles but is only adding 10 random articles from the json file, open to discussion If we should either add more or all of the articles or cherry picking some of them from the json file and limiting the amount of images we push to this repo

Randomly uses 10 articles from msq, no any specific criteria

Closes https://app.clickup.com/t/8678v8e6m

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo merged commit a70f70d into feat/articles Sep 27, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the feat/article-seeder branch September 27, 2023 11:00
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.10.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants