Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new footer design for tablet and mobile views #154

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

patricio0312rev
Copy link
Contributor

[general] UI changes on <=960px footer

Summary

  • Footer component has been refactored to support our new footer design for mobile and tablet views.
  • As part of the refactor, we now have two child components for the user named SocialIcons and PoweredBy, to make the code look cleaner.
  • Class names for the social icon buttons have been updated to match the design.

How to reproduce

  1. Run the app in local or test_e2e mode.
  2. Navigate to any page.
  3. Scroll down until you reach the bottom of the page and see the magic ✨

Views

  • 320:
    Screen Shot 2023-09-27 at 08 19 19

  • 375:
    Screen Shot 2023-09-27 at 08 19 51

  • 640:
    Screen Shot 2023-09-27 at 08 20 06

  • 768:
    Screen Shot 2023-09-27 at 08 20 24

  • 960:
    Screen Shot 2023-09-27 at 08 20 39

  • 1024:
    Screen Shot 2023-09-27 at 08 20 54

  • 1280:
    Screen Shot 2023-09-27 at 08 21 04

  • 1440:
    Screen Shot 2023-09-27 at 08 21 24

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review September 27, 2023 13:22
@ItsANameToo ItsANameToo added this to the 0.7.0 milestone Sep 27, 2023
@patricio0312rev patricio0312rev mentioned this pull request Sep 28, 2023
9 tasks
@ItsANameToo ItsANameToo merged commit d4e952d into develop Sep 28, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the refactor/footer branch September 28, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants