-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dark mode for navbar and general layout background #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have some doubts/notes about this ticket:
I am using the icon section styles, but let me know if you want it as its implementation.
|
patricio0312rev
requested review from
samharperpittam and
boldninja
as code owners
September 28, 2023 14:27
9 tasks
ItsANameToo
approved these changes
Sep 28, 2023
ItsANameToo
reviewed
Sep 29, 2023
shahin-hq
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[general] Dark Mode: navbar & general layout background
Summary
Navbar
component and its children components. (Send/Receive sidebars are still missing, since they are not part of this component).Steps to reproduce
test_e2e
ortest
mode.Settings
page.Dark mode
toggle on and see the magic ✨Checklist