-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use abortController for axios instead of axios-cancel #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricio0312rev
requested review from
samharperpittam and
boldninja
as code owners
October 5, 2023 15:08
ItsANameToo
approved these changes
Oct 6, 2023
crnkovic
approved these changes
Oct 9, 2023
ItsANameToo
pushed a commit
that referenced
this pull request
Oct 10, 2023
alfonsobries
pushed a commit
that referenced
this pull request
Oct 10, 2023
crnkovic
pushed a commit
that referenced
this pull request
Oct 12, 2023
ItsANameToo
pushed a commit
that referenced
this pull request
Oct 12, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[general] replace axios-cancel ?
Summary
axios-cancel
was no longer being maintained and its last version was launched in 2016, so it was already causing issues with dependencies.axios-cancel
has been refactored, implementingAbortController
as axios suggests in its documentation.AbortController
: axios docs and kinda code.axios-cancel
and its types have been removed frompackage.json
.Checklist