Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use abortController for axios instead of axios-cancel #186

Merged
merged 15 commits into from
Oct 9, 2023

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Oct 5, 2023

[general] replace axios-cancel ?

Summary

  • axios-cancel was no longer being maintained and its last version was launched in 2016, so it was already causing issues with dependencies.
  • The code related to axios-cancel has been refactored, implementing AbortController as axios suggests in its documentation.
  • I have based this fix on these two implementations of AbortController: axios docs and kinda code.
  • axios-cancel and its types have been removed from package.json.

NOTE: At first, I implemented CancelToken from Axios, since I have used it before. However, I noticed that it was deprecated, so I changed it to AbortController.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 5, 2023 15:08
@ItsANameToo ItsANameToo added this to the 0.7.0 milestone Oct 5, 2023
@ItsANameToo ItsANameToo modified the milestones: 0.7.0, 0.9.0 Oct 6, 2023
@ItsANameToo ItsANameToo merged commit ea7e8e0 into develop Oct 9, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the refactor/replace-axios-cancel branch October 9, 2023 15:08
ItsANameToo pushed a commit that referenced this pull request Oct 10, 2023
author Juan Patricio Marroquin <juan.marroquin1@unmsm.edu.pe> 1696515102 -0500
committer ItsANameToo <itsanametoo@protonmail.com> 1696926888 +0200

refactor: use abortController for axios instead of axios-cancel (#186)
alfonsobries pushed a commit that referenced this pull request Oct 10, 2023
author Juan Patricio Marroquin <juan.marroquin1@unmsm.edu.pe> 1696515102 -0500
committer ItsANameToo <itsanametoo@protonmail.com> 1696926888 +0200

refactor: use abortController for axios instead of axios-cancel (#186)
crnkovic pushed a commit that referenced this pull request Oct 12, 2023
author Juan Patricio Marroquin <juan.marroquin1@unmsm.edu.pe> 1696515102 -0500
committer ItsANameToo <itsanametoo@protonmail.com> 1696926888 +0200

refactor: use abortController for axios instead of axios-cancel (#186)
ItsANameToo pushed a commit that referenced this pull request Oct 12, 2023
author Juan Patricio Marroquin <juan.marroquin1@unmsm.edu.pe> 1696515102 -0500
committer ItsANameToo <itsanametoo@protonmail.com> 1696926888 +0200

refactor: use abortController for axios instead of axios-cancel (#186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants