Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user dropdown light mode UI issue #202

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

patricio0312rev
Copy link
Contributor

[navbar] user dropdown light mode UI issue

Summary

  • Styles for the hover and regular colors for the number of galleries in the user dropdown have been updated and fixed in light mode.
  • The icon size for the hamburger menu button has been updated to 20px x 20px so it can match the UI.

## Views

  • Mobile button size:
image
  • Text colors in user dropdown:
image

## Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. In desktop screen view, click on the user dropdown to see the magic ✨
  3. In mobile view, check the mobile navbar to see the magic ✨

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 10, 2023 12:09
@ItsANameToo ItsANameToo added this to the 0.7.0 milestone Oct 10, 2023
@ItsANameToo ItsANameToo merged commit 5ad20e1 into rc-0.7.0 Oct 10, 2023
@ItsANameToo ItsANameToo deleted the fix/user-dropdown-light-ui-issue branch October 10, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants