Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: articles pagination #216

Merged
merged 182 commits into from
Oct 18, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Oct 12, 2023

Summary

Closes: https://app.clickup.com/t/85zu43hpu

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Base automatically changed from feat/add-articles-page to feat/articles October 13, 2023 15:18
…tion

# Conflicts:
#	app/Http/Controllers/ArticleController.php
#	app/Http/Controllers/CollectionController.php
#	app/Models/Article.php
#	resources/js/Pages/Articles/Components/ArticlesView.tsx
#	tests/App/Models/ArticleTest.php
@shahin-hq shahin-hq marked this pull request as ready for review October 18, 2023 14:39
@shahin-hq shahin-hq merged commit faf266e into feat/articles Oct 18, 2023
16 checks passed
@shahin-hq shahin-hq deleted the refactor/collection-articles-pagination branch October 18, 2023 19:24
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.10.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants