Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit article meta description #221

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

Tickets says to limit to 250 chars but as my understanding the best practice is still 160 chars, will update if necessary

The meta-description is already passed to the article view page and if not set it uses a chunk of the content that is also limited to 160 chars

Closes https://app.clickup.com/t/8678v0d00

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the TBD milestone Oct 13, 2023
@ItsANameToo ItsANameToo merged commit 19ed8ae into feat/articles Oct 13, 2023
@ItsANameToo ItsANameToo deleted the feat/article-meta-description branch October 13, 2023 09:41
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.10.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants