Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve collections sorting speed #235

Merged
merged 1 commit into from
Oct 16, 2023
Merged

perf: improve collections sorting speed #235

merged 1 commit into from
Oct 16, 2023

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Oct 16, 2023 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/862kg19mw

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Contributor

@shahin-hq card?

@shahin-hq shahin-hq marked this pull request as draft October 16, 2023 11:02
@shahin-hq
Copy link
Contributor Author

@ItsANameToo not ready yet

samharperpittam
samharperpittam requested changes Oct 16, 2023
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst the performance of sorting collections by Recently Received has improved a lot, it seems Collections are no longer sorted by when the wallet received the NFT. Not sure if that was an issue before this PR not. But it would be nice if it could be fixed.

More detail has been provided on Slack.

@ItsANameToo ItsANameToo added this to the 0.8.0 milestone Oct 16, 2023
@shahin-hq shahin-hq marked this pull request as ready for review October 16, 2023 13:48
@ItsANameToo ItsANameToo merged commit 4e2036d into rc-0.8.0 Oct 16, 2023
18 checks passed
@ItsANameToo ItsANameToo deleted the perf/improve-collection-sorting branch October 16, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shahin-hq @ItsANameToo @samharperpittam