-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: axios cancel alternative not working #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
samharperpittam and
boldninja
as code owners
October 16, 2023 15:23
9 tasks
let data: CollectionsResponse; | ||
|
||
try { | ||
const response = await axios.get<CollectionsResponse>(decodeURIComponent(url.toString()), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🚀
patricio0312rev
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lit 🔥
ItsANameToo
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/865d85uzc
Replaces the globally added
abort controller
with a different solution (how to test below),Also with the new fix in place I noticed that the collection page was making two requests to load the collections when opened, meaning double memory usage, also was requesting the collection for guest users, fixed both issues
To test the axios cancel part you need to emulate a canceled request, that is mostly used on the search fields, so for example if a user is creating a gallery and searches for a nft, then changes the search query but the prev search request didnt finished yet, it should cancel the prev request, since is not easy to emulate that scenario you can hardcode a
sleep
method in the controller that return the response, for example, on theapp/Http/Controllers/MyGalleryCollectionController.php
you can addsleep(5)
inside the index method. since request is going to be slower if will be canceled while you search (see video)Screen.Recording.2023-10-13.at.16.06.59.mov
This apply to every component that I updated with
newAbortSignal
, is not easy to explain how to test all of them but if you have issues ping me on slack,Checklist