Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: show alternative placeholder if collection doesn't store activity #241

Merged
merged 7 commits into from
Oct 17, 2023
Merged

refactor: show alternative placeholder if collection doesn't store activity #241

merged 7 commits into from
Oct 17, 2023

Conversation

crnkovic
Copy link
Contributor

Summary

https://app.clickup.com/t/862kg611d

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

crnkovic
crnkovic commented Oct 17, 2023
View reviewed changes
config/dashbrd.php
@@ -201,7 +201,7 @@
'0x495f947276749ce646f68ac8c248420045cb7b5e', // OpenSea Shared Storefront
],

'activities_blacklist' => [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a typo on my part. this is how it should be named

@ItsANameToo ItsANameToo added this to the 0.8.0 milestone Oct 17, 2023
ItsANameToo
ItsANameToo reviewed Oct 17, 2023
View reviewed changes
lang/en/pages.php Outdated Show resolved Hide resolved
crnkovic and others added 2 commits October 17, 2023 12:17
@crnkovic @ItsANameToo
Update lang/en/pages.php
6040cc3 
Co-authored-by: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
@crnkovic @github-actions
chore: rebuild assets
1881f08
@crnkovic crnkovic marked this pull request as ready for review October 17, 2023 11:40
@ItsANameToo ItsANameToo changed the title refactor: show placeholder if collection doesn't have store activity refactor: show alternative placeholder if collection doesn't store activity Oct 17, 2023
@ItsANameToo ItsANameToo merged commit 4d73a85 into rc-0.8.0 Oct 17, 2023
22 checks passed
@ItsANameToo ItsANameToo deleted the refactor/placeholder branch October 17, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crnkovic @ItsANameToo @shahin-hq