Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle moralis spam tokens #245

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

Im just filtering the tokens with the possible_spam flag, alternatively we can store them and handle differently, open to discussion

https://app.clickup.com/t/85zu4j4ww

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Contributor

@oXtxNt9U oXtxNt9U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsobries Left one small comment, you can check if it makes sense to or just ignore it otherwise.

app/Http/Client/Moralis/MoralisPendingRequest.php Outdated Show resolved Hide resolved
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Oct 18, 2023
@alfonsobries
Copy link
Contributor Author

@crnkovic @oXtxNt9U

Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine. If we get reports from users that tokens are missing that are legit, we can look at handling it differently

@ItsANameToo ItsANameToo merged commit 69a2dfb into develop Oct 19, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the refactor/handle-spam-tokens-moralis branch October 19, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants