Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: article author box #247

Merged
merged 34 commits into from
Oct 18, 2023
Merged

feat: article author box #247

merged 34 commits into from
Oct 18, 2023

Conversation

alfonsobries
Copy link
Contributor

Summary

Depends on #246

Closes https://app.clickup.com/t/8678v0jwz

Notice that this pr modifies the article seeder so it assign the article to one of 3 random "authors", two with avatars and one without avatar

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries changed the title Feat/author box feat: article author box Oct 17, 2023
@ItsANameToo ItsANameToo added this to the TBD milestone Oct 18, 2023
Base automatically changed from feat/sharing-options to feat/articles October 18, 2023 08:51
@ItsANameToo ItsANameToo merged commit 7475d11 into feat/articles Oct 18, 2023
16 checks passed
@ItsANameToo ItsANameToo deleted the feat/author-box branch October 18, 2023 09:04
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.10.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants