Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode for my wallet page #259

Merged
merged 14 commits into from
Oct 23, 2023

Conversation

patricio0312rev
Copy link
Contributor

[general] Dark Mode: [wallet] table dark mode, [wallet] portfolio breakdown dark mode & [wallet] portfolio header dark mode

Summary

  • Dark mode has been enabled for the entire My wallet page and all its children components.
  • Portfolio breakdown slider now fully supports dark mode.
  • Table component styles have been updated to support dark mode.

Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Go to Settings and turn on the Dark mode slider.
  3. Click on your user dropdown in the navbar.
  4. Then, click on My wallet button.
  5. Navigate in the page and see the magic ✨
Screen.Recording.2023-10-20.at.09.51.42.mov

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 20, 2023 15:02
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Oct 23, 2023
@ItsANameToo ItsANameToo merged commit 4a480b9 into develop Oct 23, 2023
14 checks passed
@ItsANameToo ItsANameToo deleted the feat/dark-mode-for-my-wallet-page branch October 23, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants