refactor: article images conversions #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/865d7nd1u
I decided to solve it in a simple way:
As a reference, we used a much more complex alternative on MSQ that resulted in a lot of conversions, and we used the screen size to decide which image to use (for example, on a large screen, it might appear smaller than on a medium one due to the number of columns). In my opinion, that was an overkill solution that made it difficult to maintain and arguably didn't offer any tangible benefits.
This is just an opinion, of course, and is open to discussion.
Checklist