Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode for collection and nft details pages #270

Merged

Conversation

patricio0312rev
Copy link
Contributor

[general] dark mode: [collections] collection detail dark mode, [nfts] activity table dark mode, [nfts] header dark mode, [general] dark mode image placeholder & [general] image loading state swaps colors

Summary

  • Skeleton loader in collection page has been fixed. The purple color appearing when finishing loading has been removed.
  • Placeholder for NFT's with no image is correctly appearing.
  • New className prop for Point component.
  • Collection and NFT details pages now fully support dark mode.
Screen.Recording.2023-10-23.at.08.31.47.mov

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev marked this pull request as ready for review October 23, 2023 14:46
@ItsANameToo ItsANameToo merged commit 5de714c into develop Oct 24, 2023
12 checks passed
@ItsANameToo ItsANameToo deleted the feat/dark-mode-for-collection-and-nft-details-pages branch October 24, 2023 08:35
@ItsANameToo ItsANameToo added this to the 0.9.0 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants